feat(assignments): close and reopen assignment on person swap
This commit is contained in:
@@ -832,4 +832,113 @@ describe("asset use-cases", () => {
|
||||
newStatus: "ASSIGNED",
|
||||
})
|
||||
})
|
||||
|
||||
it("closes the old assignment and creates a new one on person swap via updateAssetUseCase", async () => {
|
||||
const actor = await createTestUser(prisma)
|
||||
const personA = await createTestPerson(prisma, { firstName: "Alice" })
|
||||
const personB = await createTestPerson(prisma, { firstName: "Bob" })
|
||||
const category = await createTestCategory(prisma)
|
||||
const item = await prisma.item.create({
|
||||
data: {
|
||||
sku: "W3-ASSET-SKU",
|
||||
name: "Asset Item",
|
||||
trackingType: "SERIALIZED",
|
||||
stock: 0,
|
||||
category: { connect: { id: category.id } },
|
||||
},
|
||||
})
|
||||
|
||||
const created = await createAssetUseCase({
|
||||
actorId: actor.id,
|
||||
itemId: item.id,
|
||||
serialNumber: "W3-ASSET-001",
|
||||
status: "ASSIGNED",
|
||||
personId: personA.id,
|
||||
})
|
||||
expect(created.success).toBe(true)
|
||||
if (!created.success) throw new Error("Expected asset creation success")
|
||||
|
||||
const oldAssignment = await prisma.assignment.findFirstOrThrow({
|
||||
where: {
|
||||
status: "OPEN",
|
||||
assetLines: { some: { assetId: created.assetId, returnedAt: null } },
|
||||
},
|
||||
})
|
||||
|
||||
const updated = await updateAssetUseCase({
|
||||
actorId: actor.id,
|
||||
id: created.assetId,
|
||||
itemId: item.id,
|
||||
serialNumber: "W3-ASSET-001",
|
||||
status: "ASSIGNED",
|
||||
personId: personB.id,
|
||||
})
|
||||
expect(updated.success).toBe(true)
|
||||
if (!updated.success) throw new Error("Expected asset update success")
|
||||
|
||||
const [oldAssignmentAfter, newAssignment, movements] = await Promise.all([
|
||||
prisma.assignment.findUniqueOrThrow({
|
||||
where: { id: oldAssignment.id },
|
||||
include: { assetLines: true },
|
||||
}),
|
||||
prisma.assignment.findFirstOrThrow({
|
||||
where: { personId: personB.id, status: "OPEN" },
|
||||
include: { assetLines: true },
|
||||
}),
|
||||
prisma.inventoryMovement.findMany({
|
||||
include: {
|
||||
stockLines: true,
|
||||
assetLines: true,
|
||||
assignment: { select: { personId: true } },
|
||||
},
|
||||
orderBy: [{ createdAt: "asc" }, { id: "asc" }],
|
||||
}),
|
||||
])
|
||||
|
||||
expect(oldAssignmentAfter.status).toBe("RETURNED")
|
||||
expect(oldAssignmentAfter.closedAt).toBeInstanceOf(Date)
|
||||
expect(oldAssignmentAfter.assetLines[0].returnedAt).toBeInstanceOf(Date)
|
||||
|
||||
expect(newAssignment.id).not.toBe(oldAssignment.id)
|
||||
expect(newAssignment.personId).toBe(personB.id)
|
||||
expect(newAssignment.assetLines[0]).toMatchObject({
|
||||
assetId: created.assetId,
|
||||
returnedAt: null,
|
||||
})
|
||||
|
||||
expect(movements).toHaveLength(3)
|
||||
expect(movements.map((m) => m.type)).toEqual([
|
||||
"ASSIGNMENT",
|
||||
"RETURN",
|
||||
"ASSIGNMENT",
|
||||
])
|
||||
for (const movement of movements) {
|
||||
expect(movement.stockLines).toEqual([])
|
||||
}
|
||||
|
||||
const returnMovement = movements[1]
|
||||
const newAssignmentMovement = movements[2]
|
||||
|
||||
expect(returnMovement).toMatchObject({
|
||||
type: "RETURN",
|
||||
assignmentId: oldAssignment.id,
|
||||
})
|
||||
expect(returnMovement.assignment).toMatchObject({
|
||||
personId: personA.id,
|
||||
})
|
||||
expect(returnMovement.assetLines[0]).toMatchObject({
|
||||
assetId: created.assetId,
|
||||
})
|
||||
|
||||
expect(newAssignmentMovement).toMatchObject({
|
||||
type: "ASSIGNMENT",
|
||||
assignmentId: newAssignment.id,
|
||||
})
|
||||
expect(newAssignmentMovement.assignment).toMatchObject({
|
||||
personId: personB.id,
|
||||
})
|
||||
expect(newAssignmentMovement.assetLines[0]).toMatchObject({
|
||||
assetId: created.assetId,
|
||||
})
|
||||
})
|
||||
})
|
||||
|
||||
@@ -644,4 +644,244 @@ describe("assignment use-cases", () => {
|
||||
expect(movements).toHaveLength(movementsBefore)
|
||||
expect(movements.some((movement) => movement.type === "ADJUSTMENT")).toBe(false)
|
||||
})
|
||||
|
||||
it("closes the old assignment and creates a new one with RETURN+ASSIGNMENT pair on person swap for QUANTITY", async () => {
|
||||
const actor = await createTestUser(prisma)
|
||||
const personA = await createTestPerson(prisma, { firstName: "Alice" })
|
||||
const personB = await createTestPerson(prisma, { firstName: "Bob" })
|
||||
const item = await createTestItem(prisma, { stock: 5 })
|
||||
|
||||
const created = await createAssignmentUseCase({
|
||||
actorId: actor.id,
|
||||
personId: personA.id,
|
||||
lines: [{ itemId: item.id, quantity: 2 }],
|
||||
})
|
||||
expect(created.success).toBe(true)
|
||||
if (!created.success) throw new Error("Expected assignment creation success")
|
||||
|
||||
const updated = await updateAssignmentUseCase({
|
||||
actorId: actor.id,
|
||||
id: created.assignmentId,
|
||||
personId: personB.id,
|
||||
lines: [{ itemId: item.id, quantity: 2 }],
|
||||
})
|
||||
expect(updated.success).toBe(true)
|
||||
if (!updated.success) throw new Error("Expected assignment update success")
|
||||
|
||||
const [oldAssignment, newAssignment, updatedItem, movements] =
|
||||
await Promise.all([
|
||||
prisma.assignment.findUniqueOrThrow({
|
||||
where: { id: created.assignmentId },
|
||||
include: { stockLines: { include: { returns: true } } },
|
||||
}),
|
||||
prisma.assignment.findFirstOrThrow({
|
||||
where: { personId: personB.id, status: "OPEN" },
|
||||
include: { stockLines: true },
|
||||
}),
|
||||
prisma.item.findUniqueOrThrow({ where: { id: item.id } }),
|
||||
prisma.inventoryMovement.findMany({
|
||||
include: {
|
||||
stockLines: true,
|
||||
assignment: { select: { personId: true } },
|
||||
},
|
||||
orderBy: [{ createdAt: "asc" }, { id: "asc" }],
|
||||
}),
|
||||
])
|
||||
|
||||
expect(oldAssignment.status).toBe("RETURNED")
|
||||
expect(oldAssignment.closedAt).toBeInstanceOf(Date)
|
||||
expect(oldAssignment.closedById).toBe(actor.id)
|
||||
expect(oldAssignment.stockLines[0].returns).toHaveLength(1)
|
||||
expect(oldAssignment.stockLines[0].returns[0]).toMatchObject({
|
||||
quantity: 2,
|
||||
receivedById: actor.id,
|
||||
})
|
||||
|
||||
expect(newAssignment.id).not.toBe(created.assignmentId)
|
||||
expect(newAssignment.personId).toBe(personB.id)
|
||||
expect(newAssignment.stockLines[0]).toMatchObject({
|
||||
itemId: item.id,
|
||||
quantity: 2,
|
||||
})
|
||||
|
||||
expect(updatedItem.stock).toBe(3)
|
||||
|
||||
expect(movements).toHaveLength(3)
|
||||
expect(movements.map((m) => m.type)).toEqual([
|
||||
"ASSIGNMENT",
|
||||
"RETURN",
|
||||
"ASSIGNMENT",
|
||||
])
|
||||
|
||||
const returnMovement = movements[1]
|
||||
const newAssignmentMovement = movements[2]
|
||||
|
||||
expect(returnMovement).toMatchObject({
|
||||
type: "RETURN",
|
||||
assignmentId: created.assignmentId,
|
||||
})
|
||||
expect(returnMovement.assignment).toMatchObject({
|
||||
personId: personA.id,
|
||||
})
|
||||
expect(returnMovement.stockLines[0]).toMatchObject({
|
||||
itemId: item.id,
|
||||
stockDelta: 2,
|
||||
previousStock: 3,
|
||||
newStock: 5,
|
||||
})
|
||||
|
||||
expect(newAssignmentMovement).toMatchObject({
|
||||
type: "ASSIGNMENT",
|
||||
assignmentId: newAssignment.id,
|
||||
})
|
||||
expect(newAssignmentMovement.assignment).toMatchObject({
|
||||
personId: personB.id,
|
||||
})
|
||||
expect(newAssignmentMovement.stockLines[0]).toMatchObject({
|
||||
itemId: item.id,
|
||||
stockDelta: -2,
|
||||
previousStock: 5,
|
||||
newStock: 3,
|
||||
})
|
||||
})
|
||||
|
||||
it("closes the old AssignmentAssetLine and creates a new one on person swap for SERIALIZED", async () => {
|
||||
const actor = await createTestUser(prisma)
|
||||
const personA = await createTestPerson(prisma, { firstName: "Alice" })
|
||||
const personB = await createTestPerson(prisma, { firstName: "Bob" })
|
||||
const category = await createTestCategory(prisma)
|
||||
const item = await prisma.item.create({
|
||||
data: {
|
||||
sku: "W3-SERIAL-SKU",
|
||||
name: "Serial Item",
|
||||
trackingType: "SERIALIZED",
|
||||
stock: 0,
|
||||
category: { connect: { id: category.id } },
|
||||
},
|
||||
})
|
||||
const asset = await prisma.asset.create({
|
||||
data: {
|
||||
serialNumber: "W3-SERIAL-ASSET-001",
|
||||
itemId: item.id,
|
||||
status: "AVAILABLE",
|
||||
},
|
||||
})
|
||||
|
||||
const created = await createAssignmentUseCase({
|
||||
actorId: actor.id,
|
||||
personId: personA.id,
|
||||
assetId: asset.id,
|
||||
lines: [{ itemId: item.id, quantity: 1 }],
|
||||
})
|
||||
expect(created.success).toBe(true)
|
||||
if (!created.success) throw new Error("Expected assignment creation success")
|
||||
|
||||
const updated = await updateAssignmentUseCase({
|
||||
actorId: actor.id,
|
||||
id: created.assignmentId,
|
||||
personId: personB.id,
|
||||
assetId: asset.id,
|
||||
lines: [{ itemId: item.id, quantity: 1 }],
|
||||
})
|
||||
expect(updated.success).toBe(true)
|
||||
if (!updated.success) throw new Error("Expected assignment update success")
|
||||
|
||||
const [oldAssignment, newAssignment, movements] = await Promise.all([
|
||||
prisma.assignment.findUniqueOrThrow({
|
||||
where: { id: created.assignmentId },
|
||||
include: { assetLines: true },
|
||||
}),
|
||||
prisma.assignment.findFirstOrThrow({
|
||||
where: { personId: personB.id, status: "OPEN" },
|
||||
include: { assetLines: true },
|
||||
}),
|
||||
prisma.inventoryMovement.findMany({
|
||||
include: {
|
||||
stockLines: true,
|
||||
assetLines: true,
|
||||
assignment: { select: { personId: true } },
|
||||
},
|
||||
orderBy: [{ createdAt: "asc" }, { id: "asc" }],
|
||||
}),
|
||||
])
|
||||
|
||||
expect(oldAssignment.status).toBe("RETURNED")
|
||||
expect(oldAssignment.closedAt).toBeInstanceOf(Date)
|
||||
expect(oldAssignment.assetLines[0].returnedAt).toBeInstanceOf(Date)
|
||||
|
||||
expect(newAssignment.id).not.toBe(created.assignmentId)
|
||||
expect(newAssignment.personId).toBe(personB.id)
|
||||
expect(newAssignment.assetLines[0]).toMatchObject({
|
||||
assetId: asset.id,
|
||||
returnedAt: null,
|
||||
})
|
||||
|
||||
expect(movements).toHaveLength(3)
|
||||
expect(movements.map((m) => m.type)).toEqual([
|
||||
"ASSIGNMENT",
|
||||
"RETURN",
|
||||
"ASSIGNMENT",
|
||||
])
|
||||
for (const movement of movements) {
|
||||
expect(movement.stockLines).toEqual([])
|
||||
}
|
||||
|
||||
const returnMovement = movements[1]
|
||||
const newAssignmentMovement = movements[2]
|
||||
|
||||
expect(returnMovement).toMatchObject({
|
||||
type: "RETURN",
|
||||
assignmentId: created.assignmentId,
|
||||
})
|
||||
expect(returnMovement.assignment).toMatchObject({
|
||||
personId: personA.id,
|
||||
})
|
||||
expect(returnMovement.assetLines[0]).toMatchObject({
|
||||
assetId: asset.id,
|
||||
})
|
||||
|
||||
expect(newAssignmentMovement).toMatchObject({
|
||||
type: "ASSIGNMENT",
|
||||
assignmentId: newAssignment.id,
|
||||
})
|
||||
expect(newAssignmentMovement.assignment).toMatchObject({
|
||||
personId: personB.id,
|
||||
})
|
||||
expect(newAssignmentMovement.assetLines[0]).toMatchObject({
|
||||
assetId: asset.id,
|
||||
})
|
||||
})
|
||||
|
||||
it("writes no RETURN or ASSIGNMENT when the person is unchanged on update with quantity change", async () => {
|
||||
const actor = await createTestUser(prisma)
|
||||
const person = await createTestPerson(prisma)
|
||||
const item = await createTestItem(prisma, { stock: 5 })
|
||||
|
||||
const created = await createAssignmentUseCase({
|
||||
actorId: actor.id,
|
||||
personId: person.id,
|
||||
lines: [{ itemId: item.id, quantity: 2 }],
|
||||
})
|
||||
expect(created.success).toBe(true)
|
||||
if (!created.success) throw new Error("Expected assignment creation success")
|
||||
|
||||
const updated = await updateAssignmentUseCase({
|
||||
actorId: actor.id,
|
||||
id: created.assignmentId,
|
||||
personId: person.id,
|
||||
lines: [{ itemId: item.id, quantity: 3 }],
|
||||
})
|
||||
expect(updated.success).toBe(true)
|
||||
if (!updated.success) throw new Error("Expected assignment update success")
|
||||
|
||||
const movements = await prisma.inventoryMovement.findMany({
|
||||
include: { stockLines: true },
|
||||
orderBy: [{ createdAt: "asc" }, { id: "asc" }],
|
||||
})
|
||||
|
||||
// ASSIGNMENT (create) + ADJUSTMENT (W-1) = 2 movements
|
||||
expect(movements).toHaveLength(2)
|
||||
expect(movements.map((m) => m.type)).toEqual(["ASSIGNMENT", "ADJUSTMENT"])
|
||||
expect(movements.some((m) => m.type === "RETURN")).toBe(false)
|
||||
})
|
||||
})
|
||||
|
||||
Reference in New Issue
Block a user